Skip to content

Commit

Permalink
drop old node versions
Browse files Browse the repository at this point in the history
  • Loading branch information
@isaacs
isaacs committed Jul 8, 2024
1 parent e01135c commit 7965d88
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
# cringe lorg

## 11.0

- Drop support for node less than v20

## 10.4

Accidental minor update, should've been patch.
- Accidental minor update, should've been patch.

## 10.3

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
"dist"
],
"engines": {
"node": "14 >= 14.21 || 16 >= 16.20 || 18 >=18.20 || 20 || >=22"
"node": "20 || >=22"
},
"prettier": {
"semi": false,
Expand Down

3 comments on commit 7965d88

@jwasnoggin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for this? Are there errors when using the library on node versions <20?

@isaacs
Copy link
Owner Author

@isaacs isaacs commented on 7965d88 Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's annoying to test, because node changed the import/loader behavior dramatically. So, no, this library is probably fine in node 18, but my tests aren't, and if I'm not testing something, I'm bound to break it eventually. Better to just make a clean break and move forward. Keep using the old version if you like, there's no harm in it, but I won't be doing work to support it.

@jwasnoggin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the response!

Please sign in to comment.