Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running fs source fails if it requires internal modules #41

Closed
vkurchatkin opened this issue Jun 5, 2015 · 2 comments
Closed

Running fs source fails if it requires internal modules #41

vkurchatkin opened this issue Jun 5, 2015 · 2 comments

Comments

@vkurchatkin
Copy link

nodejs/node#1898
vkurchatkin added a commit to vkurchatkin/node that referenced this issue Jun 5, 2015
@vkurchatkin
fs: use kMaxLength from binding
443a72c 
This allows `graceful-fs` to evaluate `fs` source
without access to internals.

See isaacs/node-graceful-fs#41

This is a temporary workaround that makes npm work.

Fixes: nodejs#1898
vkurchatkin added a commit to vkurchatkin/node that referenced this issue Jun 5, 2015
@vkurchatkin
fs: use kMaxLength from binding
4fd4838 
This allows `graceful-fs` to evaluate `fs` source
without access to internals.

This is a temporary workaround that makes npm work.

See: isaacs/node-graceful-fs#41
Fixes: nodejs#1898
vkurchatkin added a commit to nodejs/node that referenced this issue Jun 5, 2015
@vkurchatkin
fs: use kMaxLength from binding
2dcef83 
This allows `graceful-fs` to evaluate `fs` source
without access to internals.

This is a temporary workaround that makes npm work.

See: isaacs/node-graceful-fs#41
Fixes: #1898
PR-URL: #1903
Reviewed-By: Ben Noordhuis <[email protected]>
@Fishrock123
Copy link

As stated here the problem appears to be https://github.com/isaacs/node-graceful-fs/blob/master/fs.js#L8-L10 (i.e. running process.binding('natives').MODULE though eval.)

Edit: which, for point, is even commented in the source here as being evil.

@Fishrock123
Copy link

Related to #33 and 34e473a + #34 and the revert of that patch in 5eb4fee

@Fishrock123 Fishrock123 mentioned this issue Jun 5, 2015
Closed
@isaacs isaacs mentioned this issue Jun 6, 2015
Closed
@isaacs isaacs closed this as completed Jun 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@isaacs @Fishrock123 @vkurchatkin