Skip to content

Commit

Permalink
node 14 no longer supported
Browse files Browse the repository at this point in the history
  • Loading branch information
@isaacs
isaacs committed Jul 6, 2024
1 parent eef7ea3 commit 8a69def
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,6 @@
"url": "https://github.com/sponsors/isaacs"
},
"engines": {
"node": ">=16 || 14 >=14.18"
"node": ">=18"
}
}

3 comments on commit 8a69def

@timbeadle
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change, no? Convention has become "do a major bump when you drop support for an older node version".

@RickRosendaal
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite the breaking change this is..! Our build pipeline just failed because of it. Definitely should be a major bump.
Also: The "node 14 no longer supported" message to me reads as if just node 14 is no longer supported, not that node 16 is no longer supported either.

@isaacs
Copy link
Owner Author

@isaacs isaacs commented on 8a69def Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://nodejs.org/en/blog/announcements/nodejs16-eol/

It's been EOL for 10 months now. Pin your deps.

Please sign in to comment.