Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

Allow warning instead of failure on status checks #1465

Open
sffc opened this issue Jan 18, 2019 · 3 comments
Open

Allow warning instead of failure on status checks #1465

sffc opened this issue Jan 18, 2019 · 3 comments

Comments

@sffc
Copy link

sffc commented Jan 18, 2019

When creating a status on a commit, there are only four choices: error, failure, pending, or success.

https://developer.github.com/v3/repos/statuses/

It would be useful to have a level called "warning". If a commit has statuses that are all success or warning, then an orange exclamation mark should be used to annotate the commit, instead of a red X. If there is at least one failure, then you should get the red X.

This would clean up the implementation of "recommended but not required" checks for PRs. For example, in unicode-org/icu, we have a recommended policy that a PR contains only one commit. We currently have this set up as a non-required status that fails, which causes the whole PR to get the red X, even when all of the other checks are green.

@lordzsolt
Copy link

2 years later..

@sdball
Copy link

sdball commented Aug 9, 2021

🥺This would be great for steps that may fail expectedly without having to write complex checking logic around the steps to get to the same result. e.g. a step that runs "npm publish". Right now that fails if the package version hasn't been updated and it fails the entire workflow. It'd be great to be able to declare that some steps fail with a warning. That way we could see that if the build failed with a warning then the critical steps (build, test) worked but the secondary steps (publishing) failed.

@Levi-Lesches
Copy link
Contributor

This isn't the official GitHub feedback repo. Open a discussion there (and link back here) to get GitHub's attention.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants