Skip to content

[Feature Request] Throw warning instead of error if certain test cases fail #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
darrentu opened this issue Jan 13, 2023 · 1 comment
Assignees
Labels
Area-image Changes to the base/tools image feature_request New feature request Iteration-Backlog Cloud Shell team will address this in the future Status-Committed Committed item by the Cloud Shell team

Comments

@darrentu
Copy link
Contributor

Since we are pulling packages from the Mariner OS, if Mariner updates their packages, it directly affects the build. An example would be when Mariner publishes a newer version of NodeJS. When we do the build with the newer version of NodeJS, the test (that checks the downloaded version against the 'expected' version) will fail. We want to change it so that those tests throw a warning instead of an error. We still want to be aware of the version change; however, it shouldn't result a failure in our test suite which leads to a CI build failure.

@darrentu darrentu added the feature_request New feature request label Jan 13, 2023
@darrentu
Copy link
Contributor Author

darrentu commented Jan 13, 2023

With the research that I've done, it doesn't seem like there is a trivial way to throw a warning. Instead, we can have a 'continue-on-error' for the certain test cases we 'allow' to fail.

Ref:
isaacs/github#1465
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions

@dsajanice dsajanice self-assigned this Jan 19, 2023
@dsajanice dsajanice added Area-image Changes to the base/tools image Iteration-Current Cloud Shell team is addressing this currently Status-Committed Committed item by the Cloud Shell team labels Jan 19, 2023
@dsajanice dsajanice added Iteration-Backlog Cloud Shell team will address this in the future and removed Iteration-Current Cloud Shell team is addressing this currently labels Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-image Changes to the base/tools image feature_request New feature request Iteration-Backlog Cloud Shell team will address this in the future Status-Committed Committed item by the Cloud Shell team
Projects
None yet
Development

No branches or pull requests

2 participants