Skip to content
This repository has been archived by the owner on Jul 14, 2023. It is now read-only.

Remove explicit reference to the Generic.Files.LineEndings sniff #26

Merged

Conversation

aadmathijssen
Copy link
Member

@aadmathijssen aadmathijssen commented Mar 8, 2022

This PR removes the explicit inclusion of the Generic.Files.LineEndings sniff.

This is unnecessary, as this sniff is already included via the PSR12 ruleset:

    <!-- All PHP files MUST use the Unix LF (linefeed) line ending only. -->
    <rule ref="Generic.Files.LineEndings">
        <properties>
            <property name="eolChar" value="\n"/>
        </properties>
    </rule>

Note that the PSR12 ruleset explicitly specifies a value for the eolChar property, whereas the ISAAC ruleset did not. However, this doesn't make a difference, since the \n value is the default value of that property.

@jeroennoten jeroennoten merged commit 024ca09 into develop Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants