added toggle keyboard feature #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -317,6 +318,8 @@ | |||
| if (slider.settings.controls) updateDirectionControls(); | |||
| // if touchEnabled is true, setup the touch events | |||
| if (slider.settings.touchEnabled && !slider.settings.ticker) initTouch(); | |||
| // setup the keyboard events | |||
| setupKeyboard(); | |||
There was a problem hiding this comment.
I setup the keyboard anyway on start, in case the user initializes the slider without the parameter 'keyboardEnabled' set to true, but later on decides to enable it. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyboard navigation (arrows) that can be toggled to avoid conflicts.
Particularly useful in when there's great amount of pictures/slides and when used along with other plug-ins that also use keyboard navigation.