Skip to content

Commit b0f90d6

Browse files
committed
docs(thruster): add missing __init__ arg descriptions
1 parent d9348b1 commit b0f90d6

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

source/isaaclab/isaaclab/actuators/thruster.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,13 @@ def __init__(
5757
"""Construct buffers and sample per-motor parameters.
5858
5959
Args:
60-
num_envs: Number of vectorized envs.
6160
cfg: Thruster configuration.
62-
device: PyTorch device string.
61+
thruster_names: List of thruster names belonging to this group.
62+
thruster_ids: Slice or tensor of indices into the articulation thruster array.
63+
num_envs: Number of parallel/vectorized environments.
64+
device: PyTorch device string or device identifier.
65+
init_thruster_rps: Initial per-thruster rotations-per-second tensor used when
66+
the configuration uses RPM-based thrust modelling.
6367
"""
6468
self.cfg = cfg
6569
self._num_envs = num_envs
@@ -166,7 +170,6 @@ def compute(self, control_action: ArticulationThrustActions) -> ArticulationThru
166170

167171
control_action.thrusts = self.applied_thrust
168172

169-
170173
return control_action
171174

172175
def reset_idx(self, env_ids=None) -> None:

source/isaaclab_tasks/isaaclab_tasks/manager_based/drone_ntnu/mdp/rewards.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ def distance_to_goal_exp(
3939
position_error_square = torch.sum(torch.square(target_position_w - current_position), dim=1)
4040
return torch.exp(-position_error_square / std**2)
4141

42+
4243
def upright_posture_reward(
4344
env: ManagerBasedRLEnv, asset_cfg: SceneEntityCfg = SceneEntityCfg("robot"), std: float = 0.5
4445
) -> torch.Tensor:
@@ -72,6 +73,7 @@ def ang_vel_reward(
7273
angular_vel_reward = torch.exp(-ang_vel_squared / std**2)
7374
return angular_vel_reward
7475

76+
7577
def velocity_reward(
7678
env: ManagerBasedRLEnv, asset_cfg: SceneEntityCfg = SceneEntityCfg("robot"), std: float = 1.0
7779
) -> torch.Tensor:

source/isaaclab_tasks/isaaclab_tasks/manager_based/drone_ntnu/state_based_control/config/LMF2/state_based_control_env_cfg.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,9 +176,9 @@ class RewardsCfg:
176176
upright_posture = RewTerm(
177177
func=mdp.upright_posture_reward, weight=1.0, params={"asset_cfg": SceneEntityCfg("robot"), "std": 5.0} # 0.5
178178
)
179-
179+
180180
yaw_aligned = RewTerm(func=mdp.yaw_reward, weight=2.0, params={"asset_cfg": SceneEntityCfg("robot"), "std": 1.0})
181-
181+
182182
velocity_reward = RewTerm(
183183
func=mdp.velocity_reward,
184184
weight=2.5,

0 commit comments

Comments
 (0)