Skip to content

Commit 8c5b468

Browse files
authored
Fixes minor issues in CI (#3120)
# Description 1. Changed test reporter for compatibility pipeline to generate HTML report 2. Increased the number of reported logs for failed test cases to 50 (max) 3. Set execute permissions in the Dockerfile on the isaaclab.sh - sometimes the post-merge pipeline fails due to permissions 4. Updated the default Isaac SIM version
1 parent a454968 commit 8c5b468

File tree

4 files changed

+13
-5
lines changed

4 files changed

+13
-5
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ permissions:
2525
env:
2626
NGC_API_KEY: ${{ secrets.NGC_API_KEY }}
2727
ISAACSIM_BASE_IMAGE: ${{ vars.ISAACSIM_BASE_IMAGE || 'nvcr.io/nvidia/isaac-sim' }}
28-
ISAACSIM_BASE_VERSION: ${{ vars.ISAACSIM_BASE_VERSION || '4.5.0' }}
28+
ISAACSIM_BASE_VERSION: ${{ vars.ISAACSIM_BASE_VERSION || '5.0.0' }}
2929
DOCKER_IMAGE_TAG: isaac-lab-dev:${{ github.event_name == 'pull_request' && format('pr-{0}', github.event.pull_request.number) || github.ref_name }}-${{ github.sha }}
3030

3131
jobs:
@@ -186,4 +186,5 @@ jobs:
186186
reporter: java-junit
187187
fail-on-error: true
188188
only-summary: false
189+
max-annotations: '50'
189190
report-title: "IsaacLab Test Results - ${{ github.workflow }}"

.github/workflows/daily-compatibility.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -181,11 +181,15 @@ jobs:
181181
retention-days: 30
182182
compression-level: 9
183183

184-
- name: Publish Test Results
185-
uses: EnricoMi/publish-unit-test-result-action@v2
184+
- name: Report Test Results
185+
uses: dorny/test-reporter@v1
186186
if: always()
187187
with:
188-
files: "reports/combined-compat-results.xml"
188+
name: IsaacLab Compatibility Test Results
189+
path: reports/combined-compat-results.xml
190+
reporter: java-junit
191+
max-annotations: '50'
192+
report-title: "IsaacLab Compatibility Test Results - ${{ github.workflow }}"
189193

190194
notify-compatibility-status:
191195
needs: [combine-compat-results]

.github/workflows/postmerge-ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ permissions:
2222
env:
2323
NGC_API_KEY: ${{ secrets.NGC_API_KEY }}
2424
ISAACSIM_BASE_IMAGE: ${{ vars.ISAACSIM_BASE_IMAGE || 'nvcr.io/nvidia/isaac-sim' }}
25-
ISAACSIM_BASE_VERSIONS_STRING: ${{ vars.ISAACSIM_BASE_VERSIONS_STRING || 'latest-base-4.5' }}
25+
ISAACSIM_BASE_VERSIONS_STRING: ${{ vars.ISAACSIM_BASE_VERSIONS_STRING || 'latest-base-5.0' }}
2626
ISAACLAB_IMAGE_NAME: ${{ vars.ISAACLAB_IMAGE_NAME || 'isaac-lab-base' }}
2727

2828
jobs:

docker/Dockerfile.base

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,9 @@ RUN --mount=type=cache,target=/var/cache/apt \
5151
# Copy the Isaac Lab directory (files to exclude are defined in .dockerignore)
5252
COPY ../ ${ISAACLAB_PATH}
5353

54+
# Ensure isaaclab.sh has execute permissions
55+
RUN chmod +x ${ISAACLAB_PATH}/isaaclab.sh
56+
5457
# Set up a symbolic link between the installed Isaac Sim root folder and _isaac_sim in the Isaac Lab directory
5558
RUN ln -sf ${ISAACSIM_ROOT_PATH} ${ISAACLAB_PATH}/_isaac_sim
5659

0 commit comments

Comments
 (0)