fix: ignore hidden input without label

fix htmlhint#866
is2ei · Jan 27, 2022 · 39e4105 · 39e4105
1 parent fdd4c21
commit 39e4105
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 5 deletions.
diff --git a/dist/core/rules/input-requires-label.js b/dist/core/rules/input-requires-label.js
diff --git a/dist/htmlhint.js b/dist/htmlhint.js
@@ -986,7 +986,9 @@
 	            const mapAttrs = parser.getMapAttrs(event.attrs);
 	            const col = event.col + tagName.length + 1;
 	            if (tagName === 'input') {
-	                inputTags.push({ event: event, col: col, id: mapAttrs['id'] });
+	                if (mapAttrs['type'] !== 'hidden') {
+	                    inputTags.push({ event: event, col: col, id: mapAttrs['id'] });
+	                }
 	            }
 	            if (tagName === 'label') {
 	                if ('for' in mapAttrs && mapAttrs['for'] !== '') {

diff --git a/dist/htmlhint.min.js b/dist/htmlhint.min.js
diff --git a/src/core/rules/input-requires-label.ts b/src/core/rules/input-requires-label.ts
@@ -18,7 +18,10 @@ export default {
       const col = event.col + tagName.length + 1
 
       if (tagName === 'input') {
-        inputTags.push({ event: event, col: col, id: mapAttrs['id'] })
+        // label is not required for hidden input
+        if (mapAttrs['type'] !== 'hidden') {
+          inputTags.push({ event: event, col: col, id: mapAttrs['id'] })
+        }
       }
 
       if (tagName === 'label') {

diff --git a/test/rules/input-requires-label.spec.js b/test/rules/input-requires-label.spec.js
@@ -22,6 +22,13 @@ describe(`Rules: ${ruleId}`, () => {
       const messages = HTMLHint.verify(code, ruleOptions)
       expect(messages.length).to.be(0)
     })
+
+    it('Hidden input tag with no matching label should result in no error', () => {
+      const code = '<input id="some-id" type="hidden" />'
+      const messages = HTMLHint.verify(code, ruleOptions)
+      console.log(messages)
+      expect(messages.length).to.be(0)
+    })
   })
 
   describe('Error cases', () => {