Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create crescentmoon.json #17141

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Create crescentmoon.json #17141

merged 2 commits into from
Nov 13, 2024

Conversation

CrescentMoon2506
Copy link
Contributor

@CrescentMoon2506 CrescentMoon2506 requested a review from a team as a code owner November 12, 2024 17:37
@vintheweirdass

This comment was marked as outdated.

Sign in to view
@orangci
Copy link
Member

orangci commented Nov 13, 2024

This is not enough; You need to talk about yourself, not just "hi, im crescentmoon, a person..." bla bla bla

its more than enough

@orangci orangci merged commit f8d42dd into is-a-dev:main Nov 13, 2024
2 checks passed
@vintheweirdass
Copy link
Contributor

This is not enough; You need to talk about yourself, not just "hi, im crescentmoon, a person..." bla bla bla

its more than enough

oh alr, sorry for that

@CrescentMoon2506
Copy link
Contributor Author

Thanks orangci

@wdhdev
Copy link
Member

wdhdev commented Nov 14, 2024

To be honest I don't think it is enough content unless they are hosting stuff on sub pages (e.g. an API or more content)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orangci orangci orangci approved these changes

Assignees
No one assigned
Labels
domain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CrescentMoon2506 @vintheweirdass @orangci @wdhdev