Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register aryanpatel.is-a.dev #16913

Closed
wants to merge 3 commits into from
Closed

Register aryanpatel.is-a.dev #16913

wants to merge 3 commits into from

Conversation

aryanpatel142006
Copy link

Register aryanpatel.is-a.dev with CNAME record pointing to cname.vercel-dns.com..

@aryanpatel142006 aryanpatel142006 requested a review from a team as a code owner October 30, 2024 21:56
@aryanpatel142006
Copy link
Author

Hey, so I read some of the comments in the previous PRs and turns out I'll have to finish the website, before getting the domain, and I'm a beginner I just learnt hosting a website, so I'm creating my portfolio rn, so it's ok if you just close the PR, I really like it cause I'm getting my full name in the subdomain, which I never get anywhere,but I'm afraid someone might take the subdomain, so it'd be great if you could merge the PR and I'll update the website ASAP, but I totally understand if you cant't :)

Stef-00012
Stef-00012 requested changes Oct 31, 2024
View reviewed changes
domains/aryanpatel.json Outdated Show resolved Hide resolved
@Stef-00012 Stef-00012 added the reason: invalid records Your records are not valid or improper. label Oct 31, 2024
@Stef-00012
Copy link
Member

Hey, so I read some of the comments in the previous PRs and turns out I'll have to finish the website, before getting the domain, and I'm a beginner I just learnt hosting a website, so I'm creating my portfolio rn, so it's ok if you just close the PR, I really like it cause I'm getting my full name in the subdomain, which I never get anywhere,but I'm afraid someone might take the subdomain, so it'd be great if you could merge the PR and I'll update the website ASAP, but I totally understand if you cant't :)

I don't think ur name is that common that might be taken by anyone else

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2024

This pull request has been marked as stale due to inactivity and will be closed. Comment anything on this PR to prevent it

@github-actions github-actions bot added the stale label Nov 9, 2024
CuteDog5695
CuteDog5695 requested changes Nov 9, 2024
View reviewed changes
Copy link
Member

@CuteDog5695 CuteDog5695 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a preview of your website?

@CuteDog5695 CuteDog5695 added status: needs preview and removed stale reason: invalid records Your records are not valid or improper. labels Nov 9, 2024
@CuteDog5695
Copy link
Member

I'll leave this PR up until Monday, then I'll close it

@orangci
Copy link
Member

orangci commented Nov 11, 2024

I'll leave this PR up until Monday, then I'll close it

no me

@orangci orangci closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stef-00012 Stef-00012 Stef-00012 requested changes

@CuteDog5695 CuteDog5695 CuteDog5695 requested changes

Assignees
No one assigned
Labels
domain status: needs preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aryanpatel142006 @Stef-00012 @CuteDog5695 @orangci