Refactor project structure #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afritzler
force-pushed
the
enh/refactore-project-structure
branch
3 times, most recently
from
846e636 to
1043e45
Compare
github-actions
bot
added
the
documentation
Refactore the current project structure to reflect the current conventions in Go. Create top-level packages for `api`, `cmd` and keep the implementation details in the `internal` package. Also bump golang version to 1.22 and update the `golangci-lint` to v1.57.0.
afritzler
force-pushed
the
enh/refactore-project-structure
branch
from
1043e45 to
58e2dd6
Compare
lukasfrank
reviewed
Mar 20, 2024
lukasfrank
reviewed
Mar 22, 2024
lukasfrank
approved these changes
Apr 2, 2024
lukas016
pushed a commit
to opensovereigncloud/ceph-provider
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Refactore the current project structure to reflect the current conventions in Go. Create top-level packages for
api,cmdand keep the implementation details in theinternalpackage.Also bump golang version to 1.22 and update the
golangci-lintto v1.57.0.