Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconcile only VolumePool created by VolumePoolReconciler #46

Merged
merged 3 commits into from
Sep 6, 2022
Merged

Reconcile only VolumePool created by VolumePoolReconciler #46

merged 3 commits into from
Sep 6, 2022

Conversation

lukasfrank
Copy link
Member

Proposed Changes

  • Check if VolumePool was created by VolumePoolReconciler by comparing pool name
  • Adapted tests

Fixes
#42
#40

@lukasfrank lukasfrank requested a review from a team as a code owner September 6, 2022 08:50
@github-actions github-actions bot added size/M bug Something isn't working controllers labels Sep 6, 2022
afritzler
afritzler requested changes Sep 6, 2022
View reviewed changes
@afritzler afritzler merged commit d8b57f4 into main Sep 6, 2022
@afritzler afritzler deleted the fix/volumepool_controller branch September 6, 2022 10:37
afritzler pushed a commit that referenced this pull request Sep 6, 2022
@lukasfrank @afritzler
Reconcile only VolumePool created by VolumePoolReconciler (#46)
0a8ec49 
* Reconcile only pools which are created by controller

* Enhance tests

* Review comments

Removed ToDo: `io.copy` is already streaming the data (https://pkg.go.dev/io#Copy)
afritzler pushed a commit that referenced this pull request Sep 6, 2022
@lukasfrank @afritzler
Reconcile only VolumePool created by VolumePoolReconciler (#46)
0b9b29c 
* Reconcile only pools which are created by controller

* Enhance tests

* Review comments

Removed ToDo: `io.copy` is already streaming the data (https://pkg.go.dev/io#Copy)
afritzler pushed a commit that referenced this pull request Sep 6, 2022
@lukasfrank @afritzler
Reconcile only VolumePool created by VolumePoolReconciler (#46)
c05fc6c 
* Reconcile only pools which are created by controller

* Enhance tests

* Review comments

Removed ToDo: `io.copy` is already streaming the data (https://pkg.go.dev/io#Copy)
lukas016 pushed a commit to opensovereigncloud/ceph-provider that referenced this pull request May 23, 2024
@pradumnapandit
Reconcile only VolumePool created by VolumePoolReconciler (ironco…
921f5f9 
…re-dev#46)

* Reconcile only pools which are created by controller

* Enhance tests

* Review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

Assignees
No one assigned
Labels
bug Something isn't working controllers size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasfrank @afritzler