Add integraton tests #316
Merged
Add integraton tests #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afritzler
added
integration-tests
and removed
enhancement
afritzler
force-pushed
the
enh/integration-tests
branch
6 times, most recently
from
deff90b to
535d3c7
Compare
|
@lukasfrank currently the |
|
@adracus I am using go build tags to separate the integration tests from other unit tests. I am not sure if that is the most elegant way to do that. Maybe you have a better idea on how to do that. |
afritzler
force-pushed
the
enh/integration-tests
branch
from
7fbed2a to
282f625
Compare
- Start a ceph cluster using microceph inside GH runner instance - Instanciate GRPC server - Instanciate ORI client - Ensure the correct behaviour by calling the corresponding ORI methods - Ensure that the resources have been correctly created using the ceph-go rados client
- Modify the `integration-tests` target in the `Makefile` to use the `-- -ginkgo.label-filter="integration"` flag
- Remove the `//go:build integration` and `// +build integration` comments from the `integration_suite_test.go` file
- Modify the `TestIntegration_GRPCServer` function in the `integration_suite_test.go` file to include the `Label("integration")` option when calling `RunSpecs`
- Remove the `//go:build integration` and `// +build integration` comments from the `volume_craete_integration_test.go` file
Signed-off-by: Andreas Fritzler <[email protected]>
- Modify the test command to include a ginkgo label filter to exclude integration tests Signed-off-by: Andreas Fritzler <[email protected]>
afritzler
force-pushed
the
enh/integration-tests
branch
3 times, most recently
from
6318f34 to
a889c77
Compare
For now we share the |
afritzler
force-pushed
the
enh/integration-tests
branch
3 times, most recently
from
26defba to
ce3486a
Compare
afritzler
force-pushed
the
enh/integration-tests
branch
7 times, most recently
from
adfcc27 to
b92b2b3
Compare
- Add an `integration-tests` label to the `release-drafter.yml` file - Add a file matching pattern for integration tests in the `release-drafter.yml` file - Remove an unnecessary line of code in the `volume_craete_integration_test.go` file Signed-off-by: Andreas Fritzler <[email protected]>
afritzler
force-pushed
the
enh/integration-tests
branch
from
b92b2b3 to
022a96d
Compare
lukasfrank
approved these changes
Sep 7, 2023
lukas016
pushed a commit
to opensovereigncloud/ceph-provider
that referenced
this pull request
May 23, 2024
* Add integraton tests
- Start a ceph cluster using microceph inside GH runner instance
- Instanciate GRPC server
- Instanciate ORI client
- Ensure the correct behaviour by calling the corresponding ORI methods
- Ensure that the resources have been correctly created using the
ceph-go rados client
* Bump onmetal-api
* test: refactor integration testing configuration and annotations
- Modify the `integration-tests` target in the `Makefile` to use the `-- -ginkgo.label-filter="integration"` flag
- Remove the `//go:build integration` and `// +build integration` comments from the `integration_suite_test.go` file
- Modify the `TestIntegration_GRPCServer` function in the `integration_suite_test.go` file to include the `Label("integration")` option when calling `RunSpecs`
- Remove the `//go:build integration` and `// +build integration` comments from the `volume_craete_integration_test.go` file
Signed-off-by: Andreas Fritzler <[email protected]>
* test: exclude integration tests from the test command
- Modify the test command to include a ginkgo label filter to exclude integration tests
Signed-off-by: Andreas Fritzler <[email protected]>
* refactor release-drafter.yml and integration tests configuration
- Add an `integration-tests` label to the `release-drafter.yml` file
- Add a file matching pattern for integration tests in the `release-drafter.yml` file
- Remove an unnecessary line of code in the `volume_craete_integration_test.go` file
Signed-off-by: Andreas Fritzler <[email protected]>
---------
Signed-off-by: Andreas Fritzler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
onmetal-apidepsThe integration workflow only runs when the
integration-testslabel is added to a PR.The
integrationpackage contains a test suite and a first integration test for theVolumecreation flow. The basic idea is to call ORI volume provided methods and ensure via acephclient that the resources have been correctly created in the cluster.To run the integration tests locally you need to pass the
integrationlabel to ginkgo:Fixes #315