Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend VolumeReconciler tests #23

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Extend VolumeReconciler tests #23

merged 2 commits into from
Aug 25, 2022

Conversation

lukasfrank
Copy link
Member

Proposed Changes

  • Adding VolumeReconciler tests
  • Adding Status handling
  • Only create one StorageClass per NS

Fixes

  • StorageClass can't be updated with a Patch operation

@lukasfrank lukasfrank requested a review from a team as a code owner August 25, 2022 14:54
@github-actions github-actions bot added size/L controllers enhancement New feature or request labels Aug 25, 2022
@afritzler afritzler merged commit ff04071 into main Aug 25, 2022
@afritzler afritzler deleted the enh/tests branch August 25, 2022 15:21
lukas016 pushed a commit to opensovereigncloud/ceph-provider that referenced this pull request May 23, 2024
@pradumnapandit
Extend VolumeReconciler tests (ironcore-dev#23)
8109ea1 
* - test if two images in the same ns can be created
- fix duplicate storage class creation

* - test reconcile with not existing volume pool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

Assignees
No one assigned
Labels
controllers enhancement New feature or request size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasfrank @afritzler