Add image population #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afritzler
force-pushed
the
enh/image-population
branch
from
9595b85 to
8b0af00
Compare
afritzler
force-pushed
the
enh/image-population
branch
from
8b0af00 to
f85f9ab
Compare
afritzler
force-pushed
the
enh/image-population
branch
2 times, most recently
from
026845f to
73f44f5
Compare
- Add an own implementation of the populator controller. - Fix deps
afritzler
force-pushed
the
enh/image-population
branch
from
4cae8c2 to
0ae604c
Compare
afritzler
force-pushed
the
enh/image-population
branch
from
5a67757 to
cc8d4a3
Compare
afritzler
force-pushed
the
enh/image-population
branch
from
2c59ce5 to
844bde0
Compare
lukasfrank
approved these changes
Aug 23, 2022
- Extended test coverage
Co-authored-by: Lukas Frank <[email protected]>
afritzler
force-pushed
the
enh/image-population
branch
from
2ceb987 to
f6c2680
Compare
lukas016
pushed a commit
to opensovereigncloud/ceph-provider
that referenced
this pull request
May 23, 2024
* Add image population * Add `ImagePopulatorReconciler` - Add an own implementation of the populator controller. - Fix deps * Add shadow pvc for population * Add image populator tests * First working end to end test * Register image populator reconciler in main * Add docker build workflow for populator and manager * Fix tests * Add more test cases * Improve watch setup by extracting PVC UID from objs - Extended test coverage * Fix docker build workflow Co-authored-by: Lukas Frank <[email protected]> Co-authored-by: Lukas Frank <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add support for the
dataSourceRefin a PVC of typeVolume. The populator machinery will then use the.spec.Imagefrom theVolumeobject and populate via a shadow a PVC a PV (ofVolumeModeblock device) and re-map the PV claim to the original PVC.The main controller logic is derived from the Kubernetes volume populator project and adapted to use the controller-runtime controller flow: https://github.com/kubernetes-csi/lib-volume-populator/blob/master/populator-machinery/controller.go