Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoFile specified rules got picked for other video file instead of bangumi rule #57

Closed
EverettSummer opened this issue Jul 24, 2023 · 2 comments · Fixed by #58
Closed
Assignees
Labels
bug Something isn't working

Comments

@EverettSummer
Copy link
Member

There is a weird situation, I have two rules and one of them has a convert action -> sound only.
I removed two rules and created a new rule with no condition that has a convert action -> video only. but when the process began, it used the sound only profile

@EverettSummer EverettSummer added the bug Something isn't working label Jul 24, 2023
@EverettSummer
Copy link
Member Author

I got more information, I list the rule for the bangumi, I see there are two rules, one is bangumi rule and one is video file rule. that video file rule is sound only but applied for a video file.

{
    "data": [
        {
            "actions": {
                "Jo3G": {
                    "color": "#a8385d",
                    "downstreamIds": [],
                    "forceFontName": "FZZhunYuan-M02",
                    "id": "Jo3G",
                    "profile": "sound_only",
                    "type": "convert",
                    "upstreamActionIds": [
                        "LcaI"
                    ]
                },
                "LcaI": {
                    "color": "#7aa3e5",
                    "downstreamIds": [
                        "Jo3G"
                    ],
                    "extraData": {},
                    "extractFrom": "VideoFile",
                    "extractTarget": "KeepContainer",
                    "extractorId": "File",
                    "id": "LcaI",
                    "type": "extract",
                    "upstreamActionIds": []
                }
            },
            "bangumiId": "995aa5a0-4054-4d2d-b9b9-6611e2cbc4de",
            "condition": null,
            "id": "8ea3a64c-b4c9-4205-8c38-3c697126ca0d",
            "name": "",
            "priority": 0,
            "videoFileId": "d381c310-04d9-41e8-8ac4-be09a6b06480"
        },
        {
            "actions": {
                "1Klu": {
                    "color": "#7aa3e5",
                    "downstreamIds": [
                        "p-bH"
                    ],
                    "extraData": {},
                    "extractFrom": "VideoFile",
                    "extractTarget": "KeepContainer",
                    "extractorId": "File",
                    "id": "1Klu",
                    "type": "extract",
                    "upstreamActionIds": []
                },
                "p-bH": {
                    "color": "#a8385d",
                    "downstreamIds": [],
                    "forceFontName": "FZZhunYuan-M02",
                    "id": "p-bH",
                    "profile": "video_only",
                    "type": "convert",
                    "upstreamActionIds": [
                        "1Klu"
                    ]
                }
            },
            "bangumiId": "995aa5a0-4054-4d2d-b9b9-6611e2cbc4de",
            "condition": "",
            "id": "5ceb72a6-f823-4e3a-b828-c74c85d1970a",
            "name": "video only",
            "priority": 0,
            "videoFileId": null
        }
    ],
    "status": 0
}

@EverettSummer
Copy link
Member Author

from the job scheduler log, it obviously picked the sound only rule
{"level":30,"time":"2023-07-24T14:46:52.084Z","message":"condition matched","video_id":"92b03173-26ca-46df-b253-87c256a857da","video_file":{"filename":"异世界一击无双姐姐 Isekai One Turn Kill Neesan [12] 1080p 简体.mkv","fileLocalPath":"/data/download/995aa5a0-4054-4d2d-b9b9-6611e2cbc4de/zHvc2woz/异世界一击无双姐姐01-12/异世界一击无双姐姐 Isekai One Turn Kill Neesan [12] 1080p 简体.mkv","fileUri":"http://download-manager-server:8081/file/content/c21eece5-1519-445c-986e-e845169d1522?relativeFilePath=%E5%BC%82%E4%B8%96%E7%95%8C%E4%B8%80%E5%87%BB%E6%97%A0%E5%8F%8C%E5%A7%90%E5%A7%9001-12%2F%E5%BC%82%E4%B8%96%E7%95%8C%E4%B8%80%E5%87%BB%E6%97%A0%E5%8F%8C%E5%A7%90%E5%A7%90%20Isekai%20One%20Turn%20Kill%20Neesan%20%5B12%5D%201080p%20%E7%AE%80%E4%BD%93.mkv"},"rule":{"id":"8ea3a64c-b4c9-4205-8c38-3c697126ca0d","name":"","bangumiId":"995aa5a0-4054-4d2d-b9b9-6611e2cbc4de","videoFileId":"d381c310-04d9-41e8-8ac4-be09a6b06480","condition":null,"actions":{"Jo3G":{"id":"Jo3G","type":"convert","color":"#a8385d","profile":"sound_only","downstreamIds":[],"forceFontName":"FZZhunYuan-M02","upstreamActionIds":["LcaI"]},"LcaI":{"id":"LcaI","type":"extract","color":"#7aa3e5","extraData":{},"extractFrom":"VideoFile","extractorId":"File","downstreamIds":["Jo3G"],"extractTarget":"KeepContainer","upstreamActionIds":[]}},"priority":0}}

@EverettSummer EverettSummer self-assigned this Jul 24, 2023
@EverettSummer EverettSummer changed the title removed rules got picked again when processing VideoFile specified rules got picked for other video file instead of bangumi rule Jul 24, 2023
EverettSummer added a commit that referenced this issue Jul 24, 2023
EverettSummer added a commit that referenced this issue Jul 29, 2023
* fix #57, fix rule selection bug

* fix #56, when vertex manager is not started, _job may not set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant