Skip to content

Conversation

@amd-eochoalo
Copy link
Contributor

@amd-eochoalo amd-eochoalo commented Jan 23, 2026

Reverts carried forward:

Other changes:

@amd-eochoalo amd-eochoalo marked this pull request as ready for review January 23, 2026 16:10
Copy link
Contributor

@hanhanW hanhanW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, I though that the dialect is dropped in IREE. So it is not landed yet: #23133

@MaheshRavishankar
Copy link
Collaborator

We are having failing tests. I dont know if @Groverkss sent out the email on iree-discuss. Id just see if we can rebase that PR/drop Shard dialect and remove the revert.

@amd-eochoalo
Copy link
Contributor Author

We are having failing tests. I dont know if @Groverkss sent out the email on iree-discuss. Id just see if we can rebase that PR/drop Shard dialect and remove the revert.

Sorry @MaheshRavishankar I am not following. The revert has nothing to do with the shard dialect.

@amd-eochoalo
Copy link
Contributor Author

@MaheshRavishankar can you clarify if I should merge this or was your comment intended as a direction of something to do in this PR? Thanks!

@MaheshRavishankar
Copy link
Collaborator

Merge this integrate. Sorry I misread the description

Other changes:

cast shard.all_gather result type to ShapedType due to its result changing types to be AnyTypeOf<[AnyMemRef, AnyRankedTensor]> in https://github.com/llvm/llvm-project/pull/177202

I thought this was another revert.

@amd-eochoalo amd-eochoalo merged commit 56acf7e into iree-org:main Jan 23, 2026
60 of 64 checks passed
keshavvinayak01 pushed a commit that referenced this pull request Jan 27, 2026
Reverts carried forward:
* Local revert of llvm/llvm-project#169614 due
to #22649

Other changes:
* cast shard.all_gather result type to `ShapedType` due to its result
changing types to be `AnyTypeOf<[AnyMemRef, AnyRankedTensor]>` in
llvm/llvm-project#177202

Signed-off-by: Keshav Vinayak Jha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants