Fix test failures revealed by reverse iteration (nondeterminism)#23162
Merged
kuhar merged 2 commits intoiree-org:mainfrom Jan 17, 2026
Merged
Fix test failures revealed by reverse iteration (nondeterminism)#23162kuhar merged 2 commits intoiree-org:mainfrom
kuhar merged 2 commits intoiree-org:mainfrom
Conversation
kuhar
requested review from
MaheshRavishankar,
amd-eochoalo,
benvanik and
qedawkins
amd-eochoalo
approved these changes
Jan 16, 2026
Contributor
amd-eochoalo
left a comment
amd-eochoalo
left a comment
There was a problem hiding this comment.
I think this looks good, but it is my first time looking into these files. The changes in AutomaticReferenceCounting.cpp are pretty self contained so that looks good! For the changes of HoistIntoGlobals, my question would be why aren't we using dominance instead of adding opOrder? Is it too expensive?
Member
Author
|
Because two ops in sibling regions wouldn't dominate one another. I think we need total order to stay deterministic. |
Contributor
Thanks! |
keshavvinayak01
pushed a commit
that referenced
this pull request
Jan 27, 2026
) Using #23161 Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
MaheshRavishankar
pushed a commit
to MaheshRavishankar/iree
that referenced
this pull request
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using #23161