Skip to content

[Codegen][Tuner] Expose the python bindings for LinalgExt::inferScaledContractionDims and LinalgExt::isaScaledContractionOpInterface#22763

Merged
Muzammiluddin-Syed-ECE merged 6 commits intoiree-org:mainfrom
Muzammiluddin-Syed-ECE:muzasyed/bindingsfp4
Nov 27, 2025

Conversation

@Muzammiluddin-Syed-ECE
Copy link
Contributor

Exposes bindings that enable tuner support for scaled contractions.

…uner

Signed-off-by: Muzammiluddin Syed <muzasyed@amd.com>
Signed-off-by: Muzammiluddin Syed <muzasyed@amd.com>
@bangtianliu
Copy link
Contributor

bangtianliu commented Nov 26, 2025

Missing Export Declarations.

you should add new defined functions to Files: compiler/src/iree/compiler/API/api_exports.{def,ld,macos.lst,c}

Without exports, these functions won't be visible when linking against the IREE compiler library. The Python bindings won't work.

Signed-off-by: Muzammiluddin Syed <muzasyed@amd.com>
Signed-off-by: Muzammiluddin Syed <muzasyed@amd.com>
@bangtianliu
Copy link
Contributor

Here: https://releases.llvm.org/10.0.0/docs/CodingStandards.html?utm_source=chatgpt.com#commenting

Comments are important for readability and maintainability. When writing comments, write them as English prose, using proper capitalization, punctuation, etc. Aim to describe what the code is trying to do and why, not how it does it at a micro level. Here are a few important things to document:

Not just for you, also for myself lol. Very easy to leave some unnecessary code comment there.

@Muzammiluddin-Syed-ECE
Copy link
Contributor Author

Sorry about the number of grammar mistakes in this PR, I'll be more careful 😅 and thank you for the feedback

Signed-off-by: Muzammiluddin Syed <muzasyed@amd.com>
@bangtianliu
Copy link
Contributor

Also update the PR tile, since it is misleading (looks like adding new transform matcher operations for scaled matmul).

Maybe like

[Codegen][Tuner] Expose the python bindings for LinalgExt::inferScaledContractionDims and LinalgExt::isaScaledContractionOpInterface

@Muzammiluddin-Syed-ECE Muzammiluddin-Syed-ECE changed the title [bindings] Expose scaled matmul matchers in python bindings [Codegen][Tuner] Expose the python bindings for LinalgExt::inferScaledContractionDims and LinalgExt::isaScaledContractionOpInterface Nov 26, 2025
Signed-off-by: Muzammiluddin Syed <muzasyed@amd.com>
@Muzammiluddin-Syed-ECE Muzammiluddin-Syed-ECE merged commit 46fbe05 into iree-org:main Nov 27, 2025
68 of 72 checks passed
keshavvinayak01 pushed a commit that referenced this pull request Jan 27, 2026
…dContractionDims and LinalgExt::isaScaledContractionOpInterface (#22763)

Exposes bindings that enable tuner support for scaled contractions.

---------

Signed-off-by: Muzammiluddin Syed <muzasyed@amd.com>
Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants