Skip to content

[Dispatch Creation] Sink reshapes through reduction ops#22341

Draft
IanWood1 wants to merge 3 commits intoiree-org:mainfrom
IanWood1:sink_through_reduction
Draft

[Dispatch Creation] Sink reshapes through reduction ops#22341
IanWood1 wants to merge 3 commits intoiree-org:mainfrom
IanWood1:sink_through_reduction

Conversation

@IanWood1
Copy link
Contributor

@IanWood1 IanWood1 commented Oct 17, 2025

Testing for CI regressions

List of blockers:

  • This causes some missed cases for horizontal fusion a379176 (#22341)
  • Bug in dispatch creation b6ca77a (#22341)
  • UNRESOLVED: A regression when a transpose gets fused as the consumer of a matmul for the test_torch tests suite on mi325: Before PR and After PR. Possibly related to the flow bitcasts.

ci-extra: test_torch

@IanWood1
Copy link
Contributor Author

IanWood1 commented Nov 19, 2025

Looks like there is a regression when a transpose gets fused as the consumer of a matmul for the test_torch tests suite on mi325:

Before PR
After PR

IanWood1 added a commit that referenced this pull request Nov 24, 2025
Adds new compiler flag
`--dispatch-creation-enable-aggressive-reshape-movement` to enable
moving reshapes through reduction operations. The top-level flag
controls the pass option `enableReshapeMovementAcrossReductions` in
BubbleUpExpandShapes.

I have been working to enable this by default on
#22341; there are a few
issues/regressions to fix. For now, I'm adding this under a flag because
this is needed in Fusilli iree-org/fusilli#18
#22502

---------

Signed-off-by: Ian Wood <ianwood@u.northwestern.edu>
@IanWood1 IanWood1 force-pushed the sink_through_reduction branch from b6ca77a to a602e95 Compare November 24, 2025 22:28
Signed-off-by: Ian Wood <ianwood@u.northwestern.edu>
Signed-off-by: Ian Wood <ianwood@u.northwestern.edu>
Signed-off-by: Ian Wood <ianwood@u.northwestern.edu>
bangtianliu pushed a commit to bangtianliu/iree that referenced this pull request Nov 25, 2025
)

Adds new compiler flag
`--dispatch-creation-enable-aggressive-reshape-movement` to enable
moving reshapes through reduction operations. The top-level flag
controls the pass option `enableReshapeMovementAcrossReductions` in
BubbleUpExpandShapes.

I have been working to enable this by default on
iree-org#22341; there are a few
issues/regressions to fix. For now, I'm adding this under a flag because
this is needed in Fusilli iree-org/fusilli#18
iree-org#22502

---------

Signed-off-by: Ian Wood <ianwood@u.northwestern.edu>
pstarkcdpr pushed a commit to pstarkcdpr/iree that referenced this pull request Nov 28, 2025
)

Adds new compiler flag
`--dispatch-creation-enable-aggressive-reshape-movement` to enable
moving reshapes through reduction operations. The top-level flag
controls the pass option `enableReshapeMovementAcrossReductions` in
BubbleUpExpandShapes.

I have been working to enable this by default on
iree-org#22341; there are a few
issues/regressions to fix. For now, I'm adding this under a flag because
this is needed in Fusilli iree-org/fusilli#18
iree-org#22502

---------

Signed-off-by: Ian Wood <ianwood@u.northwestern.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant