Reapply "[Dispatch Creation] Rework dispatch formation logic (#21854)"#22065
Merged
Conversation
…g#21854)" (iree-org#22058) This reverts commit 087d5b9. Signed-off-by: Ian Wood <ianwood@u.northwestern.edu>
IanWood1
force-pushed
the
fix_dispatch_creation_rework
branch
2 times, most recently
from
c152295 to
5e5113a
Compare
IanWood1
requested review from
MaheshRavishankar and
hanhanW
as code owners
Signed-off-by: Ian Wood <ianwood@u.northwestern.edu>
Collaborator
Member
Author
Collaborator
Should add that to the commit message. |
hanhanW
previously approved these changes
Sep 26, 2025
Member
Author
|
This causes correctness issues with llama-70b-fp8 which need to be resolved before landing this. |
hanhanW
dismissed
their stale review
Remove my approval, since I'll be out and the codebase is not ready for this yet.
Member
Author
MaheshRavishankar
approved these changes
Oct 8, 2025
weidel-p
pushed a commit
to weidel-p/iree
that referenced
this pull request
Oct 21, 2025
…g#21854)" (iree-org#22065) Re-land dispatch creation changes with an additional check to make sure that the number of parallel/reduction iterators match (only when fusing reductions together) and that they are not permuted. This fixes the issues in iree-org#22053 and iree-org#22055 that caused the revert. --------- Signed-off-by: Ian Wood <ianwood@u.northwestern.edu> Signed-off-by: Philipp <philipp.weidel@intel.com>
pstarkcdpr
pushed a commit
to pstarkcdpr/iree
that referenced
this pull request
Nov 28, 2025
…g#21854)" (iree-org#22065) Re-land dispatch creation changes with an additional check to make sure that the number of parallel/reduction iterators match (only when fusing reductions together) and that they are not permuted. This fixes the issues in iree-org#22053 and iree-org#22055 that caused the revert. --------- Signed-off-by: Ian Wood <ianwood@u.northwestern.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-land dispatch creation changes with an additional check to make sure that the number of parallel/reduction iterators match (only when fusing reductions together) and that they are not permuted. This fixes the issues in #22053 and #22055 that caused the revert.