[Codegen] Unroll instead of linearize vector.to_elements. #21959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amd-eochoalo
force-pushed
the
eochoa/2025-09-11/drop-pattern-after-upstream-merge
branch
from
4915c92 to
b03d2d7
Compare
Groverkss
approved these changes
Sep 12, 2025
amd-eochoalo
requested review from
MaheshRavishankar,
kuhar and
qedawkins
as code owners
After: * llvm/llvm-project#157740 * llvm/llvm-project#157142 the linearization of vector.to_elements pattern can be changed to either the one now upstream or to the unrolling version. This commit changes the strategy from linearizing to unrolling. Signed-off-by: Erick Ochoa <[email protected]>
amd-eochoalo
force-pushed
the
eochoa/2025-09-11/drop-pattern-after-upstream-merge
branch
from
b03d2d7 to
6ff1234
Compare
kuhar
changed the title
kuhar
approved these changes
Sep 12, 2025
Contributor
Author
|
@kuhar , looks like a test is failing. Let me try to find out what is the issue before merging. |
Member
|
Isn't this a pre-existing issue? I can see something similar here: https://github.com/iree-org/iree/actions/runs/17685863639/job/50270953148 |
Contributor
Author
|
@kuhar ah you may be right. I didn't think about that. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After:
the linearization of vector.to_elements pattern
can be changed to either the one now upstream
or to the unrolling version.
This commit changes the strategy from linearizing
to unrolling.