[CPU] Teach TilingConfig::getVectorTileSizes about CPU lowering config. #21397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The revision updates the static construct with unique_ptr because there are invalid states. E.g., the config does not recognize GPU lowering config and different structured Codegen lowering config. In this context, we prefer factory functions to initializer methods. See https://abseil.io/tips/42 for more details. Furthermore, it updates the logic of getVectorTileSizes, which uses the mapping level index to get the right list. Signed-off-by: hanhanW <[email protected]>
jtuyls
approved these changes
Jul 17, 2025
| ? loweringConfig.getStaticTilingLevelSizes(0, /*target=*/nullptr) | ||
| .size() | ||
| : 0; | ||
| for (auto level : tilingLevelToActualLevelMap) { |
Contributor
There was a problem hiding this comment.
Suggested change
| for (auto level : tilingLevelToActualLevelMap) { | |
| for (unsigned level : tilingLevelToActualLevelMap) { |
Signed-off-by: hanhanW <[email protected]>
IanWood1
pushed a commit
to IanWood1/iree
that referenced
this pull request
Jul 18, 2025
…g. (iree-org#21397) The revision updates the static constructor with unique_ptr because there are invalid states. E.g., the config does not recognize GPU lowering config and different structured Codegen lowering configs. In this context, we prefer factory functions to initializer methods. See https://abseil.io/tips/42 for more details. Furthermore, it updates the logic of `getVectorTileSizes`, which uses the mapping level index to get the right list. Ideally, we can implement an interface method for all the specific lowering config, but we still need the generic lowering config being able to handle the case. Thus, we only update `TilingConfig` logic now, and we will do the interface way later. --------- Signed-off-by: hanhanW <[email protected]>
keshavvinayak01
pushed a commit
to keshavvinayak01/iree
that referenced
this pull request
Sep 4, 2025
…g. (iree-org#21397) The revision updates the static constructor with unique_ptr because there are invalid states. E.g., the config does not recognize GPU lowering config and different structured Codegen lowering configs. In this context, we prefer factory functions to initializer methods. See https://abseil.io/tips/42 for more details. Furthermore, it updates the logic of `getVectorTileSizes`, which uses the mapping level index to get the right list. Ideally, we can implement an interface method for all the specific lowering config, but we still need the generic lowering config being able to handle the case. Thus, we only update `TilingConfig` logic now, and we will do the interface way later. --------- Signed-off-by: hanhanW <[email protected]> Signed-off-by: keshavvinayak01 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The revision updates the static constructor with unique_ptr because there are invalid states. E.g., the config does not recognize GPU lowering config and different structured Codegen lowering configs. In this context, we prefer factory functions to initializer methods. See https://abseil.io/tips/42 for more details.
Furthermore, it updates the logic of
getVectorTileSizes, which uses the mapping level index to get the right list. Ideally, we can implement an interface method for all the specific lowering config, but we still need the generic lowering config being able to handle the case. Thus, we only updateTilingConfiglogic now, and we will do the interface way later.