Skip to content

Conversation

@hanhanW
Copy link
Contributor

@hanhanW hanhanW commented Jul 16, 2025

The revision gets the lowering config interface and relies on the TilingConfig to get the vector reduction tile sizes.

The revision gets the lowering config interface and relies on the
`TilingConfig` to get the vector reduction tile sizes.

Signed-off-by: hanhanW <[email protected]>
Copy link
Contributor

@jtuyls jtuyls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


auto maybeLoweringConfig =
getLoweringConfig<IREE::Codegen::LoweringConfigAttr>(genericOp);
auto maybeLoweringConfig = getLoweringConfig(genericOp);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use the explicit type?

Signed-off-by: hanhanW <[email protected]>
@hanhanW hanhanW enabled auto-merge (squash) July 16, 2025 20:42
@hanhanW hanhanW merged commit 3880ab1 into iree-org:main Jul 16, 2025
61 of 63 checks passed
@hanhanW hanhanW deleted the split-reduction branch July 16, 2025 21:14
IanWood1 pushed a commit to IanWood1/iree that referenced this pull request Jul 18, 2025
…-org#21391)

The revision gets the lowering config interface and relies on the
`TilingConfig` to get the vector reduction tile sizes.

---------

Signed-off-by: hanhanW <[email protected]>
keshavvinayak01 pushed a commit to keshavvinayak01/iree that referenced this pull request Sep 4, 2025
…-org#21391)

The revision gets the lowering config interface and relies on the
`TilingConfig` to get the vector reduction tile sizes.

---------

Signed-off-by: hanhanW <[email protected]>
Signed-off-by: keshavvinayak01 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants