Skip to content

[Integrate] Drop the revert of unknown type conversion in bufferization. #21243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hanhanW merged 2 commits into from
Jun 30, 2025
Merged

[Integrate] Drop the revert of unknown type conversion in bufferization. #21243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf56eed
[Integrate] Drop the revert of unknown type conversion in bufferization.
hanhanW Jun 30, 2025
bda6e02
Use static identity layout if it has static shape.
hanhanW Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions compiler/src/iree/compiler/Codegen/Common/IREEComprehensiveBufferizePass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,16 +148,13 @@ static IREEOneShotBufferizationOptions getBufferizationOptions() {

// This type converter converts tensor types to memref types when no exact
// memref type can be inferred from the context.
options.unknownTypeConverterFn = [](Value value, Attribute memorySpace,
options.unknownTypeConverterFn = [](TensorType tensorType,
Attribute memorySpace,
const BufferizationOptions &options) {
auto tensorType = llvm::cast<TensorType>(value.getType());

// Special rule for ConstantOps: These always lower to some memref with a
// static identity layout.
if (value.getDefiningOp<arith::ConstantOp>())
if (tensorType.hasStaticShape()) {
return bufferization::getMemRefTypeWithStaticIdentityLayout(tensorType,
memorySpace);

}
// Default case: Fully dynamic layout map for best compatibility.
return bufferization::getMemRefTypeWithFullyDynamicLayout(tensorType,
memorySpace);
Expand Down
11 changes: 4 additions & 7 deletions compiler/src/iree/compiler/Codegen/Common/TransformExtensions/CommonExtensions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,16 +886,13 @@ static IREEOneShotBufferizationOptions getBufferizationOptions() {

// This type converter converts tensor types to memref types when no exact
// memref type can be inferred from the context.
options.unknownTypeConverterFn = [](Value value, Attribute memorySpace,
options.unknownTypeConverterFn = [](TensorType tensorType,
Attribute memorySpace,
const BufferizationOptions &options) {
auto tensorType = llvm::cast<TensorType>(value.getType());

// Special rule for ConstantOps: These always lower to some memref with a
// static identity layout.
if (value.getDefiningOp<arith::ConstantOp>())
if (tensorType.hasStaticShape()) {
return bufferization::getMemRefTypeWithStaticIdentityLayout(tensorType,
memorySpace);

}
// Default case: Fully dynamic layout map for best compatibility.
return bufferization::getMemRefTypeWithFullyDynamicLayout(tensorType,
memorySpace);
Expand Down
2 changes: 1 addition & 1 deletion third_party/llvm-project
Open in desktop
Submodule llvm-project updated 4 files
+5 −4 mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.h
+9 −10 mlir/lib/Dialect/Bufferization/IR/BufferizableOpInterface.cpp
+2 −2 mlir/lib/Dialect/Bufferization/Transforms/Bufferize.cpp
+3 −3 mlir/lib/Dialect/SparseTensor/Transforms/SparsificationAndBufferizationPass.cpp
Loading