Bump LLVM to 4ac4726d00644f6c6b0e2de1df0d00deed0015bf #21175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasvasilache
requested review from
Groverkss,
IanWood1,
MaheshRavishankar,
antiagainst,
hanhanW,
kuhar and
qedawkins
as code owners
nicolasvasilache
force-pushed
the
users/nico/pad-attention-integrate-only
branch
from
a5d8087 to
9026569
Compare
Merged
Groverkss
force-pushed
the
users/nico/pad-attention-integrate-only
branch
from
9026569 to
60a321e
Compare
Groverkss
changed the title
Groverkss
force-pushed
the
users/nico/pad-attention-integrate-only
branch
from
60a321e to
7c18d18
Compare
Groverkss
changed the title
Max191
approved these changes
Jun 25, 2025
Contributor
Max191
left a comment
Max191
left a comment
There was a problem hiding this comment.
Stamping but I’m not able to review all the changes right now. If there are changes that need a closer look in here then might want to wait for another approval too
MaheshRavishankar
approved these changes
Jun 25, 2025
lialan
force-pushed
the
users/nico/pad-attention-integrate-only
branch
3 times, most recently
from
e662694 to
0f9eb07
Compare
lialan
force-pushed
the
users/nico/pad-attention-integrate-only
branch
from
0f9eb07 to
aa65b4e
Compare
45 tasks
nicolasvasilache
added a commit
that referenced
this pull request
Jul 6, 2025
This PR makes OnlineAttention derive from IndexingMapOpInterface and make it pad with transform.structured.pad_tiling_interface. Additionally, ensures the dynamic case pads to a constant before tiling and properly canonicalizes to constant shapes once AffineMin simplification kicks in. This requires integrating LLVM past d31ba5256327d30f264c2f671bf197877b242cde. The integrate PR is separated in #21175 --------- Signed-off-by: Nicolas Vasilache <[email protected]> Signed-off-by: Nicolas Vasilache <[email protected]> Co-authored-by: Nicolas Vasilache <[email protected]> Co-authored-by: Kunwar Grover <[email protected]>
keshavvinayak01
pushed a commit
to keshavvinayak01/iree
that referenced
this pull request
Sep 4, 2025
Carrying reverts from iree-org#21162 Also added a revert for [4d21da002a056c64231fb89ee9e4eba90080e9bb](https://github.com/llvm/llvm-project/pull/144158) (not a hard fix, just is a load bearing change that should be done as a seperate cherry pick) Adds a local commit to stablehlo to allow compiling with the new llvm patch Co-authored-by: Kunwar Grover <[email protected]> Signed-off-by: keshavvinayak01 <[email protected]>
keshavvinayak01
pushed a commit
to keshavvinayak01/iree
that referenced
this pull request
Sep 4, 2025
This PR makes OnlineAttention derive from IndexingMapOpInterface and make it pad with transform.structured.pad_tiling_interface. Additionally, ensures the dynamic case pads to a constant before tiling and properly canonicalizes to constant shapes once AffineMin simplification kicks in. This requires integrating LLVM past d31ba5256327d30f264c2f671bf197877b242cde. The integrate PR is separated in iree-org#21175 --------- Signed-off-by: Nicolas Vasilache <[email protected]> Signed-off-by: Nicolas Vasilache <[email protected]> Co-authored-by: Nicolas Vasilache <[email protected]> Co-authored-by: Kunwar Grover <[email protected]> Signed-off-by: keshavvinayak01 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carrying reverts from #21162
Also added a revert for 4d21da002a056c64231fb89ee9e4eba90080e9bb (not a hard fix, just is a load bearing change that should be done as a seperate cherry pick)
Adds a local commit to stablehlo to allow compiling with the new llvm patch