Skip to content

[Codegen][ROCM] Update pass signature in ROCDL pipeline#18426

Merged
nithinsubbiah merged 2 commits intoiree-org:mainfrom
nithinsubbiah:llvm_update_arithtoamdgpu
Sep 4, 2024
Merged

[Codegen][ROCM] Update pass signature in ROCDL pipeline#18426
nithinsubbiah merged 2 commits intoiree-org:mainfrom
nithinsubbiah:llvm_update_arithtoamdgpu

Conversation

@nithinsubbiah
Copy link
Collaborator

Recent LLVM integrate (#18384) carried a couple of reverts owing to various failures. This patch drops one of the reverts (iree-org/llvm-project@f6935c7) fixed by updating the function signature in ROCDL pipeline.

Signed-off-by: nithinsubbiah <nithinsubbiah@gmail.com>
@nithinsubbiah nithinsubbiah requested a review from kuhar September 4, 2024 18:55
@nithinsubbiah nithinsubbiah enabled auto-merge (squash) September 4, 2024 18:56
@nithinsubbiah nithinsubbiah force-pushed the llvm_update_arithtoamdgpu branch from 4913984 to 873824d Compare September 4, 2024 20:03
@nithinsubbiah nithinsubbiah requested a review from kuhar September 4, 2024 20:03
Signed-off-by: nithinsubbiah <nithinsubbiah@gmail.com>
Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nithinsubbiah nithinsubbiah merged commit d8caa8d into iree-org:main Sep 4, 2024
@nithinsubbiah nithinsubbiah deleted the llvm_update_arithtoamdgpu branch September 4, 2024 20:45
IanWood1 pushed a commit to IanWood1/iree that referenced this pull request Sep 8, 2024
Recent LLVM integrate (iree-org#18384)
carried a couple of reverts owing to various failures. This patch drops
one of the reverts
(iree-org/llvm-project@f6935c7)
fixed by updating the function signature in ROCDL pipeline.

---------

Signed-off-by: nithinsubbiah <nithinsubbiah@gmail.com>
josemonsalve2 pushed a commit to josemonsalve2/iree that referenced this pull request Sep 14, 2024
Recent LLVM integrate (iree-org#18384)
carried a couple of reverts owing to various failures. This patch drops
one of the reverts
(iree-org/llvm-project@f6935c7)
fixed by updating the function signature in ROCDL pipeline.

---------

Signed-off-by: nithinsubbiah <nithinsubbiah@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants