[Target][ROCM] Linking OCLC params as global instead of device BC. #15169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raikonenfnu
force-pushed
the
rocmLinkGlobal
branch
2 times, most recently
from
6f34ce6
to
75c3479
Compare
raikonenfnu
force-pushed
the
rocmLinkGlobal
branch
from
75c3479
to
f28a561
Compare
Thanks Ben! :) |
ramiro050
pushed a commit
to ramiro050/iree
that referenced
this pull request
Dec 19, 2023
…ree-org#15169) Linking simple parameters through globalVariables rather than bc. Based on the concept introduced in iree-org#15148
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linking simple parameters through globalVariables rather than bc.
Based on the concept introduced in #15148