Make x11iraf ready for 64 bit #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will avoid the conversion pointer -> int -> pointer which is not lossless on 64 bit.
The original code assumed that the "long" size is 4 bytes. On 64 bit machines, this is wrong; so we replace the unsigned longs with uint32_t.
`main.c` uses the function `ptsname()` which is declared in `stdlib.h` as `char *` only if this is defined. Otherwise, the return value defaults to `int`, which will not correctly convert to a pointer on 64 bit archs.
The declaration is in `stdlib.h`.
olebole
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is partially compiled from a patch found on daisukes blog.