-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove non free code #10
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olebole
force-pushed
the
Remove-non-free
branch
2 times, most recently
from
May 31, 2020 19:59
471d8f3
to
02e8c24
Compare
Merged
olebole
force-pushed
the
Remove-non-free
branch
3 times, most recently
from
June 4, 2020 06:56
5e716dc
to
2e737db
Compare
Rationale: The HTML widgets were copied from NCSA Mosaic and come with the following license: > Copyright (C) 1993, Board of Trustees of the University of Illinois > […] > > Licensee may make derivative works. However, if Licensee distributes any > derivative work based on or derived from the Software, then Licensee > will (1) notify NCSA regarding its distribution of the derivative work, > and (2) clearly notify users that such derivative work is a modified version > and not the original NCSA Mosaic distributed by the UI. The requirement to notify NCSA violates the Free Software guidelines (the "desert island" test). > Any Licensee wishing to make commercial use of the Software should contact > the UI, c/o NCSA, to negotiate an appropriate license for such commercial > use. Commercial use includes (1) integration of all or part of the source > code into a product for sale or license by or on behalf of Licensee to third > parties, or (2) distribution of the binary code or source code to third > parties that need it to utilize a commercial product sold or licensed by or > on behalf of Licensee. Limitation to non-commercial use also violates the Free Software guidelines
Rationale: These files come with the following license: > Copyright by Vladimir T. Romanovski > All rights reserved. > This library is designed for free, non-commercial software creation. It is > changeable and can be improved. The author would greatly appreciate any > advice, new components and patches of the existing programs. Commercial > usage is also possible with participation of the author. Limitation to non-commercial use violates the Free Software guidelines
This file is not used, and has the following statement in its copyright: > Copyright 1993, Slate Corporation, All Rights Reserved. > […] > You may not modify this specification without written permission from Slate > Corporation. This statement violates the Free Software guidelines
This is mainly taken from the Debian package.
THis was superceded by #20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the code that does not follow Open Source conventions from the x11iraf package.
While it is legal to distribute all files, several Linux distributions (Debian, Fedora etc.) require that the software in their repository are conform to an Open Source definition like the one from the Open Source Initiative (OSI), which requires
This PR removes some functionality, namely
the HTML widget (used f.e. for displaying the IRAF manual pages)
the Table widget
If you think this is a significant drop, please add this in a comment.
Detailed investigation
HTML widgets
The HTML widgets were copied from NCSA Mosaic and come with the following license:
x11iraf/obm/ObmW/HTML.c
Lines 22 to 27 in d70609c
The requirement to notify NCSA violates the OSI guidelines (the "desert island" test).
x11iraf/obm/ObmW/HTML.c
Lines 29 to 35 in d70609c
Limitation to non-commercial use also violates the OSI guidelines
Table widget
The source files come with the following license:
x11iraf/obm/ObmW/Table.c
Lines 7 to 10 in d70609c
Limitation to non-commercial use violates the OSI guidelines
inkstore.h
This file is not used, and has the following statement in its copyright:
x11iraf/obm/ObmW/inkstore.h
Lines 17 to 18 in d70609c
This statement (no-modify) violates the OSI guidelines