Fix system install #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `/iraf` link contradicts any file system standards and is buggy by design: It silently requires that the IRAF directory is called `iraf` by itself, which is not always the case. This symlink is also not necessary at all, since the proper install path is determined with the link of `/usr/include/iraf.h` or the `iraf` environment variable.
x11iraf is not part of the IRAF base distribution anymore.
There is some confusion about the "new IRAF root"; people think that the script will copy the files there. There is basically no use of the option to use a different root; therefore we remove both the `-r` option and the interactive question here.
|
The installation of the very old version of IRAF (before 2.16) did create a symlink of /iraf but this isn't required at least after 2.16.
Did you make new 'install' and '.travis.yml'? Where can I download them?
…-----原始邮件-----
发件人:"Ole Streicher" <[email protected]>
发送时间:2019-04-28 22:40:00 (星期日)
收件人: iraf-community/iraf <[email protected]>
抄送: wuqso <[email protected]>, Mention <[email protected]>
主题: [iraf-community/iraf] Fix system install (#85)
The system installation is somehow flaky: It tries to create a symlink as /iraf. This link contradicts any file system standards and is buggy by design: It silently requires that the IRAF directory is called iraf
by itself, which is not always the case. This symlink is also not necessary at all, since the proper install path is determined with the link of /usr/include/iraf.h or the iraf environment variable.
So, we remove the creation of this link.
Also, it tries to create links for x11iraf, which is not part of the iraf-community distribution. We also remove creation of this link.
And finally, the possibility to change the "new iraf root" is misleading (it must be the directory where the install script is in), and is therefore removed.
This closes#83.
It supercedes #84 since p_iraf is now really unused.
@wuqso, would you please test if this works for you?
You can view, comment on, or merge this pull request online at:
#85
Commit Summary
Remove the creation of the `/iraf` link in system installation
Remove X11IRAF binary link creation
Force `$pwd` as new IRAF root
File Changes
M.travis.yml (2)
Minstall (108)
Patch Links:
https://github.com/iraf-community/iraf/pull/85.patch
https://github.com/iraf-community/iraf/pull/85.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
|
|
I can install IRAF with no errors with the new installation script. But when I run ecl or cl, the system responses with 'ERROR: No /usr/local/iraf//bin.linux64/ecl.e binary found'. There is indeed no directory of bin.linux64 in /usr/local/iraf.
…-----原始邮件-----
发件人:"Ole Streicher" <[email protected]>
发送时间:2019-04-29 14:19:21 (星期一)
收件人: iraf-community/iraf <[email protected]>
抄送: wuqso <[email protected]>, Mention <[email protected]>
主题: [SPAM] Re: [iraf-community/iraf] Fix system install (#85)
install -- travis.yml is only needed for the automated tests.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Did you follow the installation instructions? Could you attach the logfile? |
|
I'm very sorry I didn't run 'make linux64' and 'make sysgen 2>$1 | tee build.log'. After these two commands, everything seems fine, although there are some warnings when executing the second command. Then I can execute some IRAF tasks, such as 'ccdlist' and 'splot'. However, I cannot find the build.log in the iraf directory.
…-----原始邮件-----
发件人:"Ole Streicher" <[email protected]>
发送时间:2019-04-29 15:15:48 (星期一)
收件人: iraf-community/iraf <[email protected]>
抄送: wuqso <[email protected]>, Mention <[email protected]>
主题: [SPAM] Re: [iraf-community/iraf] Fix system install (#85)
Did you follow the installation instructions? Could you attach the logfile?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The system installation is somehow flaky: It tries to create a symlink as
/iraf. This link contradicts any file system standards and is buggy by design: It silently requires that the IRAF directory is calledirafby itself, which is not always the case. This symlink is also not necessary at all, since the proper install path is determined with the link of
/usr/include/iraf.hor theirafenvironment variable.So, we remove the creation of this link.
Also, it tries to create links for x11iraf, which is not part of the iraf-community distribution. We also remove creation of this link.
And finally, the possibility to change the "new iraf root" is misleading (it must be the directory where the
installscript is in), and is therefore removed.This closes #83.
It supercedes #84 since
p_irafis now really unused.This will also resolve the issue reported on cloudynights.com#652947.
@wuqso, would you please test if this works for you?