NOIRLAB: fixes and cleanup for the "mkpkg" tool #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olebole
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR collects the commits from NOIRLAB IRAF with some bug fixes and argument cleanups for the mkpkg tool.
Original commits:
45b0550 - func prototype and unused args
35d5c0c - removed unused 'cx' arg from up_to_date()
f3ccac6 - fixed case fall through error
7b89e22 - fixed format overflow in do_mkpkg
e2dd6e7 - fixed hardcoded 'maxfiles' in get_dependency_list()
8c1b1a9 - func prototype and format overflow
845b1b9 - avoid string overflow
8d62931 - fix string overflow possibilities