Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The names of (some) subincludes of
hlib$libc/iraf.h
conflict with standard C library names, which has the danger to include the wrong file. Since the subincludes are meant to be included viainstead of
the file names are not part of the public interface, so we can safely rename them.
Internally, this requires to adjust a number of dependencies to these files, however.
Another change made by the PR is that the logic of avoiding double-includes changed. In the original,
iraf.h
did this:iraf/unix/hlib/libc/iraf.h
Lines 41 to 43 in 8903ef1
and the
#define D_stdio
was instdio.h
, while now everything is in the included file:which is the standard way.
This makes it easier to include files in included files, which will help when the header files are restructured.