Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use passed-in info argument for TraitType.error() #884

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Use passed-in info argument for TraitType.error() #884

merged 1 commit into from
Oct 28, 2023

Conversation

kylebarron
Copy link
Contributor

In my own project I'm subclassing TraitType to create my own traitlets, and working to provide good validation inside validate(), but my custom info messages weren't being shown to the user.

@blink1073 blink1073 added the bug label Oct 28, 2023
blink1073
blink1073 approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 3a03835 into ipython:main Oct 28, 2023
25 of 28 checks passed
@krassowski krassowski mentioned this pull request Jul 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylebarron @blink1073