Adopt sp-repo-review #883
Merged
Adopt sp-repo-review #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azjps
added a commit
to azjps/traitlets
that referenced
this pull request
Apr 18, 2024
Assigning a string value to a Set trait used to implicitly cast to a set containing the string, but it accidentally became a set of the string's characters after ipython#883. Fix this and add a unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt pypi.org/project/sp-repo-review, which has a standard set of checks for packages in the scientific python ecosystem, as seen in learn.scientific-python.org/development.
Disable strict mypy checks for now, but add types to more of the base classes.