Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ipykernel install #1310

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Fix ipykernel install #1310

merged 2 commits into from
Dec 17, 2024

Conversation

davidbrochart
Copy link
Collaborator

Closes #1309

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, thank you!

Do I guess right that the issue was introduced in #1079 by this change:

if self.subapp is not None:
+    self.subapp.start()
-    return self.subapp.start()

I wonder if return status here makes a difference for some command line applications.

@davidbrochart
Copy link
Collaborator Author

if self.subapp is not None:
+    self.subapp.start()
-    return self.subapp.start()

Actually I think we should rather revert that change, thanks for finding it.

@davidbrochart davidbrochart force-pushed the fix-install branch 2 times, most recently from bc3fe27 to a2f2ae8 Compare December 17, 2024 07:58
@minrk minrk merged commit b11d42c into ipython:main Dec 17, 2024
29 of 32 checks passed
@davidbrochart davidbrochart deleted the fix-install branch December 17, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'NoneType' object has no attribute 'start'
3 participants