Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Comm class + Fix incompatibility with ipywidgets #1097

Merged
merged 9 commits into from
Mar 17, 2023
Merged

Deprecate Comm class + Fix incompatibility with ipywidgets #1097

merged 9 commits into from
Mar 17, 2023

Conversation

martinRenou
Copy link
Contributor

@martinRenou martinRenou commented Feb 16, 2023 •
edited
Loading

@martinRenou
Copy link
Contributor Author

The downstream ipywidgets testing is expected to fail with this PR, as a new warning occurs while jupyter-widgets/ipywidgets#3533 is not merged.

I'm not sure what would be the good approach, would we need to wait for jupyter-widgets/ipywidgets#3533 to be merged, or is there a way to say that the downstream test is expected to show warnings?

@martinRenou martinRenou changed the title Deprecate Comm class Deprecate Comm class + Fix incompatibility with ipywidgets Mar 16, 2023
@martinRenou martinRenou mentioned this pull request Mar 17, 2023
Open
@martinRenou
Copy link
Contributor Author

martinRenou commented Mar 17, 2023 •
edited
Loading

I disabled tests from ipywidgets that are testing deprecation warnings. The remaining test failure on ipywidgets is not due to this PR as it can be replicated in ipywidgets core and should be fixed by jupyter-widgets/ipywidgets#3720

@martinRenou
Copy link
Contributor Author

martinRenou commented Mar 17, 2023 •
edited
Loading

Friendly ping @blink1073 :D This PR fixes the one (known) remaining issue with the new comm package introduction

blink1073
blink1073 approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I'll cut a release next week.

@blink1073 blink1073 changed the title Deprecate Comm class + Fix incompatibility with ipywidgets Deprecate Comm class + Fix incompatibility with ipywidgets (#1097)Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Mar 17, 2023
@blink1073 blink1073 merged commit e2972d7 into ipython:main Mar 17, 2023
@SylvainCorlay
Copy link
Member

Thanks!

@blink1073 blink1073 changed the title Deprecate Comm class + Fix incompatibility with ipywidgets (#1097)Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Deprecate Comm class + Fix incompatibility with ipywidgets Mar 17, 2023
@martinRenou martinRenou deleted the deprecate_comms branch March 20, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ipywidgets expects Comm, not BaseComm
3 participants
@martinRenou @SylvainCorlay @blink1073