tests: Enable invalid block blockchain tests#1088
Merged
Conversation
pdobacz
force-pushed
the
enable-inv-bloack
branch
from
b5c41b9 to
797afe1
Compare
chfast
approved these changes
Dec 17, 2024
pdobacz
force-pushed
the
enable-inv-bloack
branch
from
797afe1 to
4617eb3
Compare
gumb0
reviewed
Dec 17, 2024
pdobacz
force-pushed
the
enable-inv-bloack
branch
from
4617eb3 to
8dd19d7
Compare
hanzo-dev
pushed a commit
to luxcpp/cevm
that referenced
this pull request
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took the liberty to coarsely disable 4844 (and 4788) blockchain tests across the board, as they will be re-enabled in #1077, which needs to be rebased on top of these changes (invalid block blockchain tests handling in that branch is currently not complete!).
Before merging I'll squash the 1st and last commits together, they aim at the same thing.
Note, that a next step would be to respect the
expectExceptionfield from the test and only accept specific reasons for block invalidity. For now I only handle valid-invalid.