Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify ingest does not find the multihash entries in ad #35

Closed
masih opened this issue Jul 11, 2023 · 0 comments · Fixed by #37
Closed

verify ingest does not find the multihash entries in ad #35

masih opened this issue Jul 11, 2023 · 0 comments · Fixed by #37

Comments

@masih
Copy link
Member

masih commented Jul 11, 2023

Version 0.0.3

Verify ingest seems to not find any multihashes for an ad that clearly has entries in the ad get command. Example:

$ ipni ads get -ai '/ip4/18.184.77.157/tcp/4001/p2p/12D3KooWKMcrAZVZW8czkgiDiiHNFrs81cDtEsPXNBJMRM6eLcEc' --cid baguqeeraleumo2scmob2fctlsnyhngmqhqknkgnrubwfryvngaln3dnghtga
CID:          baguqeeraf5ggmlg5edw2eoway3rhtpetfink7q4jwkxmjigsoominp32ui6a
PreviousCID:  baguqeerahee24kvu5zvapxf4fyrr23eskzut23j6rg5plybqquieuqqiuv5q
ProviderID:   12D3KooWKMcrAZVZW8czkgiDiiHNFrs81cDtEsPXNBJMRM6eLcEc
ContextID:    cGFyc2VjLTIyOTQzNjcwMzY2MTI5OTk3ODU=
Addresses:    [/ip4/10.10.102.33/tcp/4001 /ip4/10.10.102.33/udp/4001/quic /ip4/18.184.77.157/tcp/4001 /ip4/18.184.77.157/udp/4001/quic /ip4/127.0.0.1/tcp/4001 /ip4/127.0.0.1/udp/4001/quic /ip6/::1/tcp/4001 /ip6/::1/udp/4001/quic]
Is Remove:    false
Metadata :    gBI=
Extended Providers:
   None
Signature: ✅ valid
Signed by: content provider
Entries:
  Chunk Count: 1
  Total Count: 301

But when verifying ingest, no multihashes are checked for the ad:

ipni verify ingest -i indexstar.prod.cid.contact --pid 12D3KooWKMcrAZVZW8czkgiDiiHNFrs81cDtEsPXNBJMRM6eLcEc -a baguqeeraf5ggmlg5edw2eoway3rhtpetfink7q4jwkxmjigsoominp32ui6a --edl 10000
Publisher: {12D3KooWKMcrAZVZW8czkgiDiiHNFrs81cDtEsPXNBJMRM6eLcEc: [/ip4/18.184.77.157/tcp/4001]}
Ads/Entries depth: 1/10000
Topic: /indexer/ingest/mainnet
Last ad seen by indexer: baguqeeraf5ggmlg5edw2eoway3rhtpetfink7q4jwkxmjigsoominp32ui6a
Verification starting at advertisement specified: baguqeeraf5ggmlg5edw2eoway3rhtpetfink7q4jwkxmjigsoominp32ui6a

Advertisement ID:          baguqeeraf5ggmlg5edw2eoway3rhtpetfink7q4jwkxmjigsoominp32ui6a
Previous Advertisement ID: baguqeerahee24kvu5zvapxf4fyrr23eskzut23j6rg5plybqquieuqqiuv5q
Verifying ingest... (1/1)
Total Entries:             0 over 0 chunk(s); ad entries are partially synced due to: recursion limit reached
Verification: 🔘 Skipped; sampling did not include any multihashes.
-----------------------

Verification result:
  # failed to verify:                   0
  # unindexed:                          0
  # indexed with another provider ID:   0
  # indexed with expected provider ID:  0
--------------------------------------------
total Multihashes checked:              0

sampling probability:                   1.00
RNG seed:                               0

⚠️ Inconclusive; no multihashes were verified.

Advertisement chain a:
  # rm ads:                             0
  # non-rm ads:                         1
     # of which had ctx id removed:     0
  # unique context IDs:                 1
  # max mhs per ad:                     0
  # min mhs per ad:                     0
  # mean ± std mhs per ad:              0.00 ± 0.00
  # max chunks per ad:                  0
  # min chunks per ad:                  0
  # mean ± std chunks per ad:           0.00 ± 0.00
--------------------------------------------
total ads:                              1
total mhs:                              0
total chunks:                           0

Note that setting entries depth limit makes no difference and the output seems to indicate:

0 over 0 chunk(s); ad entries are partially synced due to: recursion limit reached
gammazero added a commit that referenced this issue Jul 13, 2023
- Need to sync entries before sampling
- Verify can now do a double-hashed find
- Make dh and non-dh verify configurable with --no-prov flag
- Optionally allow separate dhstore and indexers (provider sources) to be specified

Fixes #35
gammazero added a commit that referenced this issue Jul 18, 2023
* Fix entry verification

- Need to sync entries before sampling
- Verify can now do a double-hashed find
- Make dh and non-dh verify configurable with --no-prov flag
- Optionally allow separate dhstore and indexers (provider sources) to be specified

Fixes #35

* No IndexCount, do not auto-refresh pcache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant