Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log context canceled messages at debug level #174

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

gammazero
Copy link
Collaborator

@gammazero gammazero commented Sep 27, 2023

Context canceled messages are flooding the logs and making it difficult to find more meaningful messages.

Fixes #173

Context canceled messages are flooding the logs and making it difficult to find more menaingful messages.

Fixes #173
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (7b968ed) 6.85% compared to head (28e1514) 6.74%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #174      +/-   ##
========================================
- Coverage   6.85%   6.74%   -0.12%     
========================================
  Files         11      11              
  Lines       1356    1364       +8     
========================================
- Hits          93      92       -1     
- Misses      1258    1265       +7     
- Partials       5       7       +2     
Files Coverage Δ
scatter_gather.go 81.96% <0.00%> (-4.48%) ⬇️
find.go 0.00% <0.00%> (ø)
find_ndjson.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gammazero gammazero merged commit 16f670b into main Sep 27, 2023
@gammazero gammazero deleted the reduce-log-noise branch September 27, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce logging of canceled contexts
2 participants