-
Notifications
You must be signed in to change notification settings - Fork 20
Backwards compatible pure data model API #184
Conversation
Wow, nice work. I just tested it also with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, just a few small points.
Summary of few updates I've made:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me (once the protons dep is updated, and I wouldn't mind seeing consistency retained with arrow function parens as per notes I've left). I hope we have solid integration tests covering all of this when it propagates upward!
@achingbrain I believe I've addressed all your comments and comments from @rvagg. @vmx I hope you agree with my arguments to decouple this from switch to https://github.com/mapbox/pbf, I do not know what errors may arise from that change & I do not want to block my primary work on that. Please let me know if there is anything else to be done, or if this can land. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 very nice work
this will probably have to wait for @vmx to return from vacation to get published, unless there's some urgency
@vmx any chance you could get to this sometime this week ? I can't make any more progress on ipfs/js-ipfs#3081 without this. |
@Gozala any objections if I release this as 0.19? It's been quite a big change and I don't want to have regressions sneaked it. |
@vmx that sounds good to me. Thanks |
This pull request attempts to add pure Data Model API interop (as per #173) in a backwards compatible way. High level overview of the changes are:
node.Data
.Only visible change is that
node.Links
no longer returns links mapped to pure data, but ratherDAGLink
instances. However it should not matter in practice because those were made to behave just like pure data would. Although tests had to be change to use.containSubset
instead of.eql
because later fails when prototype chain is different.