node/bindnode: support pointers to datamodel.Node to bind with Any #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We missed calling nonPtrVal in a few places when reading from Go values. The added test case panicked due to the missing call in _structIterator. Note that the added test case only covers one of the nonPtrVal calls, but I reckon this is enough for now, given the consistency in the code. The other modified lines are still covered by existing tests, just not with the particular pointer interaction. Rod ran into the same panic while developing go-graphsync, so this should also help unblock their progress.
rvagg
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
👍 but this is working fine without any fixes, just needing to be careful about the pointer type (filecoin-project/go-data-transfer#305)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit message)