Assert OpenReader from file does not panic after closure
#212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Write a test that asserts reader instantiated from `OpenReader` do not panic and instead error gracefully if underlying IO is closed. Relates to #211
masih
force-pushed
the
masih/test-open-reader
branch
from
3fad94d
to
912af7d
Compare
|
Thanks @masih for the quick turnaround. Closing this as the issue is related to |
|
Oops, I wanted to close the issue, not the PR that adds the tests :D |
@raulk As punishment can I get a review on this PR please 🙏 |
willscott
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write a test that asserts reader instantiated from
OpenReaderdo notpanic and instead error gracefully if underlying IO is closed.
Fixes #211