Skip to content

Conversation

@fsdiogo
Copy link
Contributor

@fsdiogo fsdiogo commented Jan 30, 2019

This makes ipld-explorer work with the new api changes from IPLD.

Also switched from source-map-explorer to webpack-bundle-analyzer.

Ref: ipfs/ipfs-webui#948

Copy link
Member

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fsdiogo
Copy link
Contributor Author

fsdiogo commented Jan 31, 2019

I can't figure out why Travis is always failing. If I checkout master it fails there too.

@olizilla
Copy link
Member

olizilla commented Feb 6, 2019

You can debug the e2e tests by running DEBUG=true npm run test:e2e

I'm seeing a js-ipfs init error when running via puppeteer, which is weird, I don't see this when running locally.

Failed to initialise js-ipfs Error: No resolver found for codec "undefined"
    at IPLDResolver.put (index.js:221)
    at DAGNode.create (object.js:135)
    at multihashing (create.js:53)
    at Multihashing.Multihashing.digest (index.js:33)
    at index.js:15
    at run (setImmediate.js:40)
    at runIfPresent (setImmediate.js:69)
    at onGlobalMessage (setImmediate.js:109)

screenshot 2019-02-06 at 12 03 56

@olizilla
Copy link
Member

olizilla commented Feb 6, 2019

The test passes on master, worth noting that you either have to be running app before starting npm run test:e2e or you can run them both with npm run test:e2e:ci

@olizilla
Copy link
Member

olizilla commented Feb 6, 2019

Oooh, i am able to recreate this locally if I delete all the indexedDB instances for the localhost:3000

@olizilla
Copy link
Member

olizilla commented Feb 6, 2019

So the good news is that the smoke test caught an issue, we need to update js-ipfs on this PR!
The bad news is that the latest js-ipfs contains fancy spread operators that create-react-app won't transpile in deps, so I need to go and raise PRs to fix that.

- Update to latest IPFS to fix IPLD api compat issues
- Update to create-react-app v2 to fix > ES2015 compilation issues from ipfs-mfs using spread operator
- Remove webpack config hack
- Bundle stats now generated by CRA
- Removed multipled unused deps

License: MIT
Signed-off-by: Oli Evans <[email protected]>
License: MIT
Signed-off-by: Oli Evans <[email protected]>
- remove lint step from travis. switching to prettier
- pin bable-core version while ipld-explorer-components depends on older one. see:
facebook/create-react-app#5259

License: MIT
Signed-off-by: Oli Evans <[email protected]>
@olizilla olizilla merged commit 0669da2 into master Feb 11, 2019
@olizilla olizilla deleted the chore/update-ipld branch February 11, 2019 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants