[fix] Make signal handler optional #390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes problem with boot 1.70
…input directory and output file path.
Update websocket.h function "void do_read()"
using with instead of open and close removed while loop using one line to write the new file using unordered map instead of ordered map added indentation to the generated file
…le command would just hang until timeout without fully sending the file). Added 404 and fixed some issues with windows error message sendfile still incompatible with windows due to the stat function also changed the buffer size to 16KB
Test cannot actually test whether the file was sent or not since the test has no access to the socket itself (also idk how to get data that was passed through a socket)
Serving static files using read() and asio::write()
Settable server name feature
recieve response without request being another argument in handler
cmake install rules
|
Hi, First off thanks for bringing this up. But unfortunately this repo hasn't been maintained in almost 3 years. A few people and I are maintaining a separate version here. Feel free to open any issues or make this same PR there. However I'll still implement this and run the tests and everything if you choose not to. |
|
Oh thanks for letting me know! I'll try making a pr over there instead |
|
See CrowCpp/Crow#85 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edit:
to remove:
app.signal_clear().port(<port>).multithreaded().run()to add back:
app.signal_add(int signal_number)