Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slight modification in scripts #207

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

Taimoor-12
Copy link
Contributor

@Taimoor-12 Taimoor-12 commented Feb 13, 2024

deb.sh scripts require root privileges to execute instead of using sudo directly in it.

Naming issue in matchip's script is already fixed. A new release of the CLI and users updating to this new version would fix most of the issues occurring in a Pod environment.

@Taimoor-12
Copy link
Contributor Author

@UmanShahzad

Copy link
Contributor

@UmanShahzad UmanShahzad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking to just run sudo if it's available as a command otherwise run it without?

@UmanShahzad UmanShahzad merged commit 12e1ee2 into ipinfo:master Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants