Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mac OS convenience script #204

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Conversation

abu-usama
Copy link
Contributor

Check success of previous commands before proceeding, fix for issue #201

@abu-usama abu-usama requested a review from UmanShahzad January 12, 2024 06:29
Copy link
Contributor

@UmanShahzad UmanShahzad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we just do a set -e or something in the script?

@abu-usama abu-usama requested a review from UmanShahzad January 16, 2024 05:11
@UmanShahzad UmanShahzad merged commit 27260c4 into master Jan 16, 2024
@UmanShahzad UmanShahzad deleted the usama/false-fail-indication branch January 16, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants