feat: improved resource manager based on Rainbow #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
approved these changes
May 21, 2024
There was a problem hiding this comment.
Thank you! lgtm, small cosmetic asks inline, once addressed feel free to ship and deploy to delegated-ipfs.dev
(I tried to stress-test this locally and no issues, but since we were running with more strict limits, once deployed, please eyeball if relaxing things here comes with any unexpected consequences in our infra.)
cc @aschmahmann for visibility (he added original defaults in https://github.com/ipfs/someguy/pull/7/files).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #64.
This improves the resource manager defaults based on what is done in Rainbow and Kubo. I also added flags so that users have the freedom to change the settings.
@lidel this seems to fix the issue for me.